Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(icons): improve pixel perfection and curvature of signature #2293

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

karsa-mistmere
Copy link
Member

What is the purpose of this pull request?

  • Bug fix

Description

The new signature icon added in #2248 is markedly off-grid at several places, this PR moves it around so that pixel perfection is improved. Also includes some optimisation & somewhat more fluid curvatures.

Before Submitting

@github-actions github-actions bot added the 🎨 icon About new icons label Jul 6, 2024
Copy link

github-actions bot commented Jul 6, 2024

Added or changed icons

icons/signature.svg

Preview cohesion icons/square-kanban.svg
icons/signature.svg
icons/file-axis-3d.svg
Preview stroke widths icons/signature.svg
icons/signature.svg
icons/signature.svg
DPI Preview (24px) icons/signature.svg
Icon X-rays icons/signature.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const SignatureIcon = createLucideIcon('Signature', [
  ["path",{"d":"m21 17-2.156-1.868A.5.5 0 0 0 18 15.5v.5a1 1 0 0 1-1 1h-2a1 1 0 0 1-1-1c0-2.545-3.991-3.97-8.5-4a1 1 0 0 0 0 5c4.153 0 4.745-11.295 5.708-13.5a2.5 2.5 0 1 1 3.31 3.284"}],
  ["path",{"d":"M3 21h18"}]
])

@karsa-mistmere karsa-mistmere changed the title Icon fix/signature chore(icons): improve pixel perfection and curvature of signature Jul 6, 2024
@ericfennis ericfennis merged commit 2539470 into main Jul 7, 2024
7 of 8 checks passed
@ericfennis ericfennis deleted the icon-fix/signature branch July 7, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants