-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): added clock/calendar-arrow-up/down icons #2307
Conversation
Added or changed iconsIcons as codeWorks for: const CalendarArrowDownIcon = createLucideIcon('CalendarArrowDown', [
["path",{"d":"m14 18 4 4 4-4"}],
["path",{"d":"M16 2v4"}],
["path",{"d":"M18 14v8"}],
["path",{"d":"M21 11.354V6a2 2 0 0 0-2-2H5a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h7.343"}],
["path",{"d":"M3 10h18"}],
["path",{"d":"M8 2v4"}]
])
const CalendarArrowUpIcon = createLucideIcon('CalendarArrowUp', [
["path",{"d":"m14 18 4-4 4 4"}],
["path",{"d":"M16 2v4"}],
["path",{"d":"M18 22v-8"}],
["path",{"d":"M21 11.343V6a2 2 0 0 0-2-2H5a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h9"}],
["path",{"d":"M3 10h18"}],
["path",{"d":"M8 2v4"}]
])
const ClockArrowDownIcon = createLucideIcon('ClockArrowDown', [
["path",{"d":"M12.338 21.994A10 10 0 1 1 21.925 13.227"}],
["path",{"d":"M12 6v6l2 1"}],
["path",{"d":"m14 18 4 4 4-4"}],
["path",{"d":"M18 14v8"}]
])
const ClockArrowUpIcon = createLucideIcon('ClockArrowUp', [
["path",{"d":"M13.228 21.925A10 10 0 1 1 21.994 12.338"}],
["path",{"d":"M12 6v6l1.562.781"}],
["path",{"d":"m14 18 4-4 4 4"}],
["path",{"d":"M18 22v-8"}]
]) |
icons/calendar-arrow-down.json
Outdated
"event", | ||
"sort", | ||
"order", | ||
"descending" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericfennis, @jguddas Not sure about these, I followed the tags from earlier sort icons, but to me arrow-down
would mean ascending and arrow-up
descending. 🤔
Maybe we should add both tags to both, just in case. 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add both tags to both, just in case. 🤷♂️
I say yes to adding both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say yes to adding both.
Done!
closes #2177
What is the purpose of this pull request?
Icon use case
see #2177
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting