Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added clock/calendar-arrow-up/down icons #2307

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

karsa-mistmere
Copy link
Member

closes #2177

What is the purpose of this pull request?

  • New Icon

Icon use case

see #2177

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Added or changed icons

icons/calendar-arrow-down.svgicons/calendar-arrow-up.svgicons/clock-arrow-down.svgicons/clock-arrow-up.svg

Preview cohesion icons/square-stack.svgicons/square-dot.svgicons/square-chevron-right.svgicons/square-user-round.svg
icons/calendar-arrow-down.svgicons/calendar-arrow-up.svgicons/clock-arrow-down.svgicons/clock-arrow-up.svg
icons/notepad-text-dashed.svgicons/mic.svgicons/arrow-big-up-dash.svgicons/scissors.svg
Preview stroke widths icons/calendar-arrow-down.svgicons/calendar-arrow-up.svgicons/clock-arrow-down.svgicons/clock-arrow-up.svg
icons/calendar-arrow-down.svgicons/calendar-arrow-up.svgicons/clock-arrow-down.svgicons/clock-arrow-up.svg
icons/calendar-arrow-down.svgicons/calendar-arrow-up.svgicons/clock-arrow-down.svgicons/clock-arrow-up.svg
DPI Preview (24px) icons/calendar-arrow-down.svg icons/calendar-arrow-up.svg icons/clock-arrow-down.svg icons/clock-arrow-up.svg
Icon X-rays icons/calendar-arrow-down.svg icons/calendar-arrow-up.svg icons/clock-arrow-down.svg icons/clock-arrow-up.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const CalendarArrowDownIcon = createLucideIcon('CalendarArrowDown', [
  ["path",{"d":"m14 18 4 4 4-4"}],
  ["path",{"d":"M16 2v4"}],
  ["path",{"d":"M18 14v8"}],
  ["path",{"d":"M21 11.354V6a2 2 0 0 0-2-2H5a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h7.343"}],
  ["path",{"d":"M3 10h18"}],
  ["path",{"d":"M8 2v4"}]
])

const CalendarArrowUpIcon = createLucideIcon('CalendarArrowUp', [
  ["path",{"d":"m14 18 4-4 4 4"}],
  ["path",{"d":"M16 2v4"}],
  ["path",{"d":"M18 22v-8"}],
  ["path",{"d":"M21 11.343V6a2 2 0 0 0-2-2H5a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h9"}],
  ["path",{"d":"M3 10h18"}],
  ["path",{"d":"M8 2v4"}]
])

const ClockArrowDownIcon = createLucideIcon('ClockArrowDown', [
  ["path",{"d":"M12.338 21.994A10 10 0 1 1 21.925 13.227"}],
  ["path",{"d":"M12 6v6l2 1"}],
  ["path",{"d":"m14 18 4 4 4-4"}],
  ["path",{"d":"M18 14v8"}]
])

const ClockArrowUpIcon = createLucideIcon('ClockArrowUp', [
  ["path",{"d":"M13.228 21.925A10 10 0 1 1 21.994 12.338"}],
  ["path",{"d":"M12 6v6l1.562.781"}],
  ["path",{"d":"m14 18 4-4 4 4"}],
  ["path",{"d":"M18 22v-8"}]
])

"event",
"sort",
"order",
"descending"
Copy link
Member Author

@karsa-mistmere karsa-mistmere Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericfennis, @jguddas Not sure about these, I followed the tags from earlier sort icons, but to me arrow-down would mean ascending and arrow-up descending. 🤔

Maybe we should add both tags to both, just in case. 🤷‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add both tags to both, just in case. 🤷‍♂️

I say yes to adding both.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say yes to adding both.

Done!

@karsa-mistmere karsa-mistmere merged commit 7c62c7c into main Jul 9, 2024
8 checks passed
@karsa-mistmere karsa-mistmere deleted the icon/clock-calendar-arrow-up-down branch July 9, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort by date icons
3 participants