-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icons): add table-of-contents icon #2348
Conversation
Added or changed iconsIcons as codeWorks for: const TableOfContentsIcon = createLucideIcon('TableOfContents', [
["path",{"d":"M16 12H3"}],
["path",{"d":"M16 18H3"}],
["path",{"d":"M16 6H3"}],
["path",{"d":"M21 12h.01"}],
["path",{"d":"M21 18h.01"}],
["path",{"d":"M21 6h.01"}]
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like having rotated and flipped versions is kinda WET(not Don'tRepeatYourself), not really a fan, even tho the use cases are really solid.
Part agree, part disagree, hear me out:
We could in theory add clever stuff to our JSONs that decrease redundancy in our SVG files, e.g.:
{
...,
"generateFrom": ["list", ["flip-x"]]
}
{
...,
"generateFrom": ["arrow-right", ["rotate-90deg", "flip-y"]]
} But up until we have something like this, I think "duplicate" icons are fine. |
Yeah, it's not really blocking, just something to think about. What about naming conventions for flipped icons maybe |
@jguddas Yeah, I get your points, but on the other side, why make a complex system that will rotate icons when we can just rotate the "design" ourselves? It's not worth the effort I think. |
closes #1859 (up for debate)
What is the purpose of this pull request?
Description
Adds a ToC icon.
Icon use case
Alternative icon designs
n/a
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting