Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): changed book-dashed icon #2399

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Aug 24, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Changed dash length to be similar to square-dashed.
The dashes are also no on the same level on each side.

Before Submitting

@github-actions github-actions bot added the 🎨 icon About new icons label Aug 24, 2024
Copy link

github-actions bot commented Aug 24, 2024

Added or changed icons

icons/book-dashed.svg

Preview cohesion icons/square-arrow-up-right.svg
icons/book-dashed.svg
icons/timer-off.svg
Preview stroke widths icons/book-dashed.svg
icons/book-dashed.svg
icons/book-dashed.svg
DPI Preview (24px) icons/book-dashed.svg
Icon X-rays icons/book-dashed.svg
Icon Diffs icons/book-dashed.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const BookDashedIcon = createLucideIcon('BookDashed', [
  ["path",{"d":"M12 17h1.5"}],
  ["path",{"d":"M12 22h1.5"}],
  ["path",{"d":"M12 2h1.5"}],
  ["path",{"d":"M17.5 22H19a1 1 0 0 0 1-1"}],
  ["path",{"d":"M17.5 2H19a1 1 0 0 1 1 1v1.5"}],
  ["path",{"d":"M20 14v3h-2.5"}],
  ["path",{"d":"M20 8.5V10"}],
  ["path",{"d":"M4 10V8.5"}],
  ["path",{"d":"M4 19.5V14"}],
  ["path",{"d":"M4 4.5A2.5 2.5 0 0 1 6.5 2H8"}],
  ["path",{"d":"M8 22H6.5a1 1 0 0 1 0-5H8"}]
])

@karsa-mistmere
Copy link
Member

Since this isn't the same size, I'd prefer pixel perfection over uniformity.

@jguddas
Copy link
Member Author

jguddas commented Aug 24, 2024

The upside here is also that it's more symmetrical.

@jguddas
Copy link
Member Author

jguddas commented Aug 24, 2024

This would be pixel perfect and symetrical.

icons
Open lucide studio

@karsa-mistmere karsa-mistmere merged commit 67cbce6 into lucide-icons:main Dec 5, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants