Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons/bell): Lucide-ify bell icons #2656

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix(icons/bell): Lucide-ify bell icons #2656

merged 1 commit into from
Dec 5, 2024

Conversation

karsa-mistmere
Copy link
Member

What is the purpose of this pull request?

  • Icon update

Description

Adds more Lucide-compliant rounded corners to bell-* icons.

Icon Design Checklist

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added the 🎨 icon About new icons label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Added or changed icons

icons/bell-dot.svgicons/bell-minus.svgicons/bell-off.svgicons/bell-plus.svgicons/bell-ring.svgicons/bell.svg

Preview cohesion icons/message-square-reply.svgicons/square-terminal.svgicons/square-split-vertical.svgicons/square-arrow-out-down-left.svgicons/square-divide.svgicons/square-minus.svg
icons/bell-dot.svgicons/bell-minus.svgicons/bell-off.svgicons/bell-plus.svgicons/bell-ring.svgicons/bell.svg
icons/calendar.svgicons/circle-fading-plus.svgicons/shield.svgicons/clipboard-minus.svgicons/square-arrow-down.svgicons/locate-off.svg
Preview stroke widths icons/bell-dot.svgicons/bell-minus.svgicons/bell-off.svgicons/bell-plus.svgicons/bell-ring.svgicons/bell.svg
icons/bell-dot.svgicons/bell-minus.svgicons/bell-off.svgicons/bell-plus.svgicons/bell-ring.svgicons/bell.svg
icons/bell-dot.svgicons/bell-minus.svgicons/bell-off.svgicons/bell-plus.svgicons/bell-ring.svgicons/bell.svg
DPI Preview (24px) icons/bell-dot.svg icons/bell-minus.svg icons/bell-off.svg icons/bell-plus.svg icons/bell-ring.svg icons/bell.svg
Icon X-rays icons/bell-dot.svg icons/bell-minus.svg icons/bell-off.svg icons/bell-plus.svg icons/bell-ring.svg icons/bell.svg
Icon Diffs icons/bell-dot.svg icons/bell-minus.svg icons/bell-off.svg icons/bell-plus.svg icons/bell-ring.svg icons/bell.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const BellDotIcon = createLucideIcon('BellDot', [
  ["path",{"d":"M10.268 21a2 2 0 0 0 3.464 0"}],
  ["path",{"d":"M13.916 2.314A6 6 0 0 0 6 8c0 4.499-1.411 5.956-2.74 7.327A1 1 0 0 0 4 17h16a1 1 0 0 0 .74-1.673 9 9 0 0 1-.585-.665"}],
  ["circle",{"cx":"18","cy":"8","r":"3"}]
])

const BellMinusIcon = createLucideIcon('BellMinus', [
  ["path",{"d":"M10.268 21a2 2 0 0 0 3.464 0"}],
  ["path",{"d":"M15 8h6"}],
  ["path",{"d":"M16.243 3.757A6 6 0 0 0 6 8c0 4.499-1.411 5.956-2.738 7.326A1 1 0 0 0 4 17h16a1 1 0 0 0 .74-1.673A9.4 9.4 0 0 1 18.667 12"}]
])

const BellOffIcon = createLucideIcon('BellOff', [
  ["path",{"d":"M10.268 21a2 2 0 0 0 3.464 0"}],
  ["path",{"d":"M17 17H4a1 1 0 0 1-.74-1.673C4.59 13.956 6 12.499 6 8a6 6 0 0 1 .258-1.742"}],
  ["path",{"d":"m2 2 20 20"}],
  ["path",{"d":"M8.668 3.01A6 6 0 0 1 18 8c0 2.687.77 4.653 1.707 6.05"}]
])

const BellPlusIcon = createLucideIcon('BellPlus', [
  ["path",{"d":"M10.268 21a2 2 0 0 0 3.464 0"}],
  ["path",{"d":"M15 8h6"}],
  ["path",{"d":"M18 5v6"}],
  ["path",{"d":"M20.002 14.464a9 9 0 0 0 .738.863A1 1 0 0 1 20 17H4a1 1 0 0 1-.74-1.673C4.59 13.956 6 12.499 6 8a6 6 0 0 1 8.75-5.332"}]
])

const BellRingIcon = createLucideIcon('BellRing', [
  ["path",{"d":"M10.268 21a2 2 0 0 0 3.464 0"}],
  ["path",{"d":"M22 8c0-2.3-.8-4.3-2-6"}],
  ["path",{"d":"M3.262 15.326A1 1 0 0 0 4 17h16a1 1 0 0 0 .74-1.673C19.41 13.956 18 12.499 18 8A6 6 0 0 0 6 8c0 4.499-1.411 5.956-2.738 7.326"}],
  ["path",{"d":"M4 2C2.8 3.7 2 5.7 2 8"}]
])

const BellIcon = createLucideIcon('Bell', [
  ["path",{"d":"M10.268 21a2 2 0 0 0 3.464 0"}],
  ["path",{"d":"M3.262 15.326A1 1 0 0 0 4 17h16a1 1 0 0 0 .74-1.673C19.41 13.956 18 12.499 18 8A6 6 0 0 0 6 8c0 4.499-1.411 5.956-2.738 7.326"}]
])

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @karsa-mistmere, love it! 🚀

@ericfennis ericfennis merged commit 53c61c0 into main Dec 5, 2024
8 checks passed
@ericfennis ericfennis deleted the icon-fix/bell branch December 5, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants