Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README file #5

Merged
merged 5 commits into from
Sep 19, 2022
Merged

Conversation

SaptarshiSarkar12
Copy link
Contributor

Added link to the License file in the Readme for easy access.

Added link to the License file in the Readme for easy access.
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #5 (5c1df75) into main (f55abc2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          926       926           
  Branches        87        87           
=========================================
  Hits           926       926           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@luciferreeves
Copy link
Owner

It seems like your changes fail to build. Take a look at the Details of the run to see the error, you might need to fix. Also, I do not feel like there's a need for adding the license to the readme though. Would like to hear your reasoning as well.

@SaptarshiSarkar12
Copy link
Contributor Author

@luciferreeves I have added a few more things in the Readme for it's enhancement. I have also fixed the error that you mentioned previously by fixing it with the correct link. Now, you can re-review this PR.

@SaptarshiSarkar12
Copy link
Contributor Author

@luciferreeves please check why ci is failing, I think there is problem in that work flow file

@luciferreeves
Copy link
Owner

The workflow file seems fine. You might wanna look at this line - It says, warning: check: Title underline too short. (line 158), which means exactly what it says. This is a problem with rst documents. You could look into the Sphinx Documentation for a fix though. Would you like me to help take care of this PR and fix the issues for you, or you want to do them yourself?

@SaptarshiSarkar12
Copy link
Contributor Author

I am having less knowledge about rst files, so if you can fix this issue, then I request you to solve it. @luciferreeves

@luciferreeves
Copy link
Owner

Great, you can leave the PR open for now. I will push some more commits to refactor some things and then I will merge it.

@SaptarshiSarkar12
Copy link
Contributor Author

Thanks @luciferreeves

@SaptarshiSarkar12
Copy link
Contributor Author

Great, you can leave the PR open for now. I will push some more commits to refactor some things and then I will merge it.

@luciferreeves How far is the work done?

@luciferreeves luciferreeves merged commit 504ae3c into luciferreeves:main Sep 19, 2022
@SaptarshiSarkar12
Copy link
Contributor Author

@luciferreeves thank you for your cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants