fix(lockfiles): unstage yarn.lock
instead of ignoring it
#241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
Based on facebook/create-react-app#2014 (comment). So in summary:
package-lock.json
from.gitignore
because we already setpackage-lock=false
in.npmrc
yarn.lock
I decided to always unstage it inpre-commit
hook to prevent it to get merged in our repo.How Has This Been Tested?
npm
/yarn
package-lock.json
,pre-commit
hook always unstageyarn.lock
Screenshots (if appropriate):
N/A
Does this PR introduce a breaking change?
Checklist:
contributing.md
.