create_nf_lib: Replace minus with underscore #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Names with minus in them are not present in the Nerd Font instance names, they follow the pattern "nf_<set>_<name>" where there are no minus (dash) characters in the name. [how] Replace all minuses with underscores when generating the entries. [note] Also fix typo/rename leftover. Signed-off-by: Fini Jastrow <[email protected]>
|
Thanks for the excellent script, btw 💚 |
hasecilu
approved these changes
Oct 28, 2024
|
This was the script that I should have done the very first time I sent a PR to Nerd-Fonts (with font-logos update), like half of that was automated and the other half filled by hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
Names with minus in them are not present in the Nerd Font instance names, they follow the pattern
"nf_<set>_<name>"where there are no minus (dash) characters in the name.[how]
Replace all minuses with underscores when generating the entries.
[note]
Also fix typo/rename leftover.
Turned up when creating