Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.8 compatibility #26

Closed
afbora opened this issue Dec 17, 2022 · 3 comments
Closed

3.8 compatibility #26

afbora opened this issue Dec 17, 2022 · 3 comments

Comments

@afbora
Copy link

afbora commented Dec 17, 2022 •
edited
Loading

  • Missing composer.json version
  • Plugin name doesn't match with getkirby.com

getkirby/kirby#4713
@lukasleitsch
Copy link
Owner

Version was added to composer.json.

@afbora Do you know if it is possible to change the name on getkirby.com? I'm using leitsch as my vendor name (Namespace and packagist). Would be great if getkirby.com could use the same vendor name.

afbora added a commit to getkirby/getkirby.com that referenced this issue Dec 28, 2022
@afbora
Update lukasleitsch vendor name with leitsch
96a9661 
lukasleitsch/kirby-blade#26
@afbora
Copy link
Author

afbora commented Dec 28, 2022

✅ Done. Thank you 🎉

@afbora afbora closed this as completed Dec 28, 2022
@lukasleitsch
Copy link
Owner

Thanks for renaming it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukasleitsch @afbora