Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some problems in httpie.d.ts #8

Merged
merged 2 commits into from Feb 2, 2019
Merged

Fix some problems in httpie.d.ts #8

merged 2 commits into from Feb 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2019

I found some problems in the .d.ts file when trying to use httpie with TypeScript, so I fixed them:

  • opts now has type Partial<HttpieOptions> since you don't have to give all 3 options.
  • The T in send<T>() and method<T>() now has default type any instead of the implicit {}

@codecov-io
Copy link

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          40     40           
=====================================
  Hits           40     40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c5505...2b1ddc9. Read the comment docs.

Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! As a non-TypeScripter, this actually makes sense to me :D Also didn't know Partial was a thing ... good to know 👍

@lukeed lukeed merged commit 9438f0e into lukeed:master Feb 2, 2019
@ghost
Copy link
Author

ghost commented Feb 3, 2019

Thanks. I can use httpie in my projects now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants