Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletes build directory from remote and ignores it #1

Closed
wants to merge 1 commit into from

Conversation

Nick-Gabe
Copy link
Contributor

Build files by concept shouldn't be sent to the remote, as they're heavy and are generated way faster than they're downloaded (my git took some seconds haha, 31k lines 😅)

@lunaperegrina
Copy link
Owner

but if I do this, the npx command don't work properly because not everybody has bun or typescript installed, correct? (e pq q a gente ta falando em ingles lindo? kdaksdjaskdj oiii nick 💖)

@Nick-Gabe
Copy link
Contributor Author

Nick-Gabe commented Feb 23, 2024

Foi mal, costume hahaha (oiii pedroo 💝)
Mas se o caso de uso é disponibilizar pra quem não consegue buildar sozinho e só quer rodar, vale mais a pena criar releases com a build separada, assim fica até mais escopado e a pessoa não precisa baixar um bando de código junto que ela não vai usar
https://github.com/pedroperegrinaa/tabnews-cli/releases/new

@Nick-Gabe
Copy link
Contributor Author

Vi uns commits sobre a build, isso foi resolvido? @pedroperegrinaa
Se sim pode fechar o pr

@lunaperegrina
Copy link
Owner

O problema inicial sim. Não tinha fechado ainda por querer implementar uma build com GitHub Packages, mas acredito que isso pode entrar em outro momento. Muito obrigada!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants