Handle Wayland screens by using their names #2006
Open
+66
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason behind this change is that screen setting by using numbers may not work with all Wayland compositors. With this patch, and on Wayland, the screen names are used for saving the arrangements of desktop items. No change is made to X11 desktops. NOTE: This is a backward incompatible change, in the sense that the arrangement of Wayland desktop items will be rest at first. But Wayland users could copy the contents of `desktop-items-0.conf` and paste it into `desktop-items-SCREEN_NAME.conf` after stopping the desktop module. That couldn't be done by the code, because it isn't known to which screen the old config file belonged (the number proves nothing).
stefonarch
approved these changes
Jan 22, 2025
|
The strange thing here is that — according to our tests — we can't keep a desktop without its screen (otherwise, a crash will be imminent), but we could do so in the case of lxqt-panel (lxqt/lxqt-panel#2226). I wonder if we were just lucky with lxqt-panel, or Wayland makes an exception for the background layer and doesn't keep it without its screen. @marcusbritanicus? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason behind this change is that screen setting by using numbers may not work with all Wayland compositors.
With this patch, and on Wayland, the screen names are used for saving the arrangements of desktop items.
No change is made to X11 desktops.
NOTE: This is a backward incompatible change, in the sense that the arrangement of Wayland desktop items will be reset at first. But Wayland users could copy the contents of
desktop-items-0.confand paste it intodesktop-items-SCREEN_NAME.confafter stopping the desktop module. That couldn't be done by the code, because it isn't known to which screen the old config file belonged (the number proves nothing).