Log users and the credentials they obtain #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-lane
reviewed
Nov 19, 2019
confidant/routes/v1.py
Outdated
| @@ -392,6 +392,9 @@ def get_credential(id): | |||
| cipher = CipherManager(data_key, cipher_version) | |||
| _credential_pairs = cipher.decrypt(cred.credential_pairs) | |||
| _credential_pairs = json.loads(_credential_pairs) | |||
|
|
|||
| if authnz.user_is_user_type('user'): | |||
| logging.info(f"{authnz.get_logged_in_user()} fetching credential {id}") | |||
There was a problem hiding this comment.
confidant is still python2 compat, so ideally use .format(), rather than f strings
There was a problem hiding this comment.
Thanks Ryan, good point.
skiptomyliu
changed the title
SecPrez
reviewed
Nov 19, 2019
skiptomyliu
changed the title
ryan-lane
previously approved these changes
Dec 20, 2019
ryan-lane
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log users and the credentials that they obtain. Useful for auditing and alerting.