Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor non-route code into services, and move root services #208

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Refactor non-route code into services, and move root services #208

merged 2 commits into from
Dec 5, 2019

Conversation

ryan-lane
Copy link
Contributor

@ryan-lane ryan-lane commented Dec 5, 2019 •
edited
Loading

Refactor shared service code into services directory to help with further refactors.

skiptomyliu
skiptomyliu approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@skiptomyliu skiptomyliu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Tested and ran on local. Looks to be a noop and a sane refactor.

@ryan-lane ryan-lane merged commit dbc7a4e into master Dec 5, 2019
@ryan-lane ryan-lane deleted the refactor-routes branch December 5, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skiptomyliu skiptomyliu skiptomyliu approved these changes

@surbhivj6 surbhivj6 Awaiting requested review from surbhivj6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-lane @skiptomyliu