Refactor resources view to match history view for resource toggling #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
skiptomyliu
previously approved these changes
Dec 20, 2019
skiptomyliu
approved these changes
Dec 20, 2019
skiptomyliu
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the resources view to be consistent with the history view for resources. Rather than showing all resources of one type in the same list, there's a toggle view between credentials, blind credentials, and services. I also pulled the create toggle into the same row as the toggles, and away from the filter, which was confusing for folks in the past.
This change also adds links to a resource's history from the details view. It also styles the action callout buttons (create, edit, save, revert) to make them more apparent.