Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate create service rbac check into its own call #249

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Separate create service rbac check into its own call #249

merged 3 commits into from
Jan 10, 2020

Conversation

skiptomyliu
Copy link
Member

@skiptomyliu skiptomyliu commented Jan 10, 2020 •
edited
Loading

  • Check that a user is able to create a service before calling the rbac check to determine if they're able to map credentials
  • Small wording changes on mapping credential deny
  • additional unit testing in credential manager

@skiptomyliu skiptomyliu requested a review from ryan-lane January 10, 2020 01:46
@skiptomyliu skiptomyliu merged commit 8c9c707 into master Jan 10, 2020
@ryan-lane ryan-lane deleted the create_service_check_2 branch February 14, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-lane ryan-lane ryan-lane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skiptomyliu @ryan-lane