Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage for list, get, and diff credential #254

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Coverage for list, get, and diff credential #254

merged 3 commits into from
Jan 14, 2020

Conversation

ryan-lane
Copy link
Contributor

@ryan-lane ryan-lane commented Jan 14, 2020 •
edited
Loading

This adds coverage for lift, get and diff credential routes. It also slightly refactors Credential.decrypted_credential_pairs so that it's easier to mock, to avoid KMS calls.

@ryan-lane ryan-lane requested a review from skiptomyliu January 14, 2020 22:27
@ryan-lane ryan-lane merged commit 63d9a75 into master Jan 14, 2020
@ryan-lane ryan-lane deleted the more-coverage-credentials branch January 14, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skiptomyliu skiptomyliu skiptomyliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-lane @skiptomyliu