Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 compatibility fixes for flask-session #258

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

apakulov-stripe
Copy link
Contributor

@apakulov-stripe apakulov-stripe commented Feb 8, 2020

This PR addressing the following issues:

 [2020-02-07 23:06:02.669077] ERROR:confidant.app:Exception on /v1/services [GET]
 [2020-02-07 23:06:02.669105] Traceback (most recent call last):
 [2020-02-07 23:06:02.669214]   File "/vendor3/lib/python3.7/site-packages/flask/app.py", line 2445, in wsgi_app
 [2020-02-07 23:06:02.669260]     ctx.push()
 [2020-02-07 23:06:02.669311]   File “/vendor3/lib/python3.7/site-packages/flask/ctx.py", line 390, in push
 [2020-02-07 23:06:02.669351]     self.session = session_interface.open_session(self.app, self.request)
 [2020-02-07 23:06:02.669608]   File "/vendor3/lib/python3.7/site-packages/flask_session/sessions.py", line 118, in open_session
 [2020-02-07 23:06:02.669662]     val = self.redis.get(self.key_prefix + sid)
 [2020-02-07 23:06:02.669714] TypeError: can only concatenate str (not "bytes") to str
 [2020-02-07 23:06:02.669755] ERROR:confidant.app:Request finalizing failed with an error while handling an error

@ryan-lane
Copy link
Contributor

Thanks for the PR! Taking a look.

@ryan-lane ryan-lane merged commit 5c48b47 into lyft:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants