Bump gevent and greenlet dependencies for Python 3.7 compatibility #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the rollout of
confidant 5.2.0
we ran into a number of issues with Python 3.7.First of all
pypi
does not have python3.7 binaries forgevent 1.2.1
: https://pypi.org/project/gevent/1.2.1/#files and same forgreenlet 0.4.12
: https://pypi.org/project/greenlet/0.4.12/#filesI tried bumping
gevent
to1.3.0
andgreenlet
to0.4.14
, butgevent
workers were segfaulting after the startup with the following log statements:After enabling https://docs.python.org/3/library/faulthandler.html we were able to get the actual stacktrace:
Bumping both dependencies to the latest stable version resolved the segfaults above.