Use ACL for both user and service checks #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skiptomyliu
reviewed
Feb 12, 2020
| resource_type='service', | ||
| action=action, | ||
| resource_id=id, | ||
| logged_in_user = authnz.get_logged_in_user() |
There was a problem hiding this comment.
having trouble seeing it at moment, but if it's a service, will this return the service name?
There was a problem hiding this comment.
nevermind, i think i see it, it will return the service/role name
https://github.com/lyft/confidant/blob/master/confidant/authnz/__init__.py#L191
There was a problem hiding this comment.
Yep! We set g.username whether it's user or service auth.
skiptomyliu
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the special-cased code for controlling authz for services, and moves everything to using ACL checks. I've added a new default ACL function
default_acl, which replicates the default behavior of service authz, while making it possible to fully apply ACL checks against services or users for all resources.