Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate a credential's tag attribute #278

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Populate a credential's tag attribute #278

merged 1 commit into from
Mar 23, 2020

Conversation

irhkang
Copy link
Contributor

@irhkang irhkang commented Mar 23, 2020

We haven't set the credential tags attribute that we added in #270.

  • We always populate tags upon creation
  • When updating a credential, we update the tags only if the "tags" field is present in the request
  • When reverting a credential, we use the tag of the revert credential.

@irhkang irhkang requested a review from ryan-lane March 23, 2020 18:45
@irhkang irhkang merged commit 79e1f77 into master Mar 23, 2020
@irhkang irhkang deleted the G-tags branch March 23, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants