Only load credential pairs in UI if user asks to unmask or edits #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-lane
commented
Mar 27, 2020
irhkang
reviewed
Mar 27, 2020
skiptomyliu
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the auditing and last-viewed behavior of confidant by only fetching decrypted credential pairs when necessary for the UI. If the end-user loads a credential, it loads
metadata_only=Trueby default, and if they unmask the credentials, or edit the credential, it'll fetch the credential withmetadata_only=False, fetching the credential pairs, and replacing them in-place in the view. The view will keep them loaded while in the same credential view, and will not re-fetch the credential for unmask/edit, as long as the user doesn't leave and re-visit the page.