Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ENABLE_SAVE_LAST_DECRYPTION_TIME
is enabled and the eye icon is clicked, confidant returns a 5xx because thelast_rotation_date
field of the response is trying to compare a tz unaware timestamp with a tz aware timestamp. Essentially what was happening was:Essentially, had we refetched the object (did another
Credential.get(123)
), we wouldn't have this problem but we were using the unsaved object.Instead of using datetime.now() we create a new method that automatically adds a tzinfo.
(Side note: Why python's datetime.utcnow() doesn't have a tzinfo in it is beyond me)