Adding new credentials to ACL module check for services #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skiptomyliu
reviewed
Feb 13, 2023
confidant/routes/services.py
Outdated
| @@ -579,12 +579,16 @@ def map_service_credentials(id): | |||
| credentials = data.get('credentials', []) | |||
| blind_credentials = data.get('blind_credentials', []) | |||
| combined_credentials = credentials + blind_credentials | |||
| new_credentials = set(combined_credentials).difference( | |||
| _service.credentials + _service.blind_credentials | |||
There was a problem hiding this comment.
Does _service.credentials return a list of ids? Making sure it does not return an object / dictionary of some sort.
There was a problem hiding this comment.
good catch, it's actually a set so just changed to union()
skiptomyliu
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.