-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid empty startedAt to crash console #221
avoid empty startedAt to crash console #221
Conversation
Thank you for opening this pull request! 🙌 |
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
=========================================
Coverage ? 63.55%
=========================================
Files ? 363
Lines ? 7790
Branches ? 1359
=========================================
Hits ? 4951
Misses ? 2839
Partials ? 0 Continue to review full report at Codecov.
|
Signed-off-by: Babis Kiosidis <[email protected]>
7222fb5
to
1dcd778
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jsonporter could you merge this? I am not authorized to merge |
Congrats on merging your first pull request! 🎉 |
## [0.28.1](http://github.com/lyft/flyteconsole/compare/v0.28.0...v0.28.1) (2021-09-30) ### Bug Fixes * **ui:** avoid empty startedAt to crash console ([#221](http://github.com/lyft/flyteconsole/issues/221)) ([42fa5ce](http://github.com/lyft/flyteconsole/commit/42fa5ce34fdc4672bf394326e56b898bdaf9abc1))
🎉 This PR is included in version 0.28.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
TL;DR
Please replace this text with a description of what this PR accomplishes.
This code is failing if an execution is still on UNKNOWN phase.
When the execution transitions to QUEUED/RUNNING then it stops crashing
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/