Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: recent workflow bug on filtering executions #264

Merged
merged 1 commit into from
Jan 14, 2022
Merged

fix: recent workflow bug on filtering executions #264

merged 1 commit into from
Jan 14, 2022

Conversation

Pianist038801
Copy link
Contributor

@Pianist038801 Pianist038801 commented Jan 13, 2022 •
edited by anrusina
Loading

Signed-off-by: Pianist038801 [email protected]
BUG-2065

This fixes a bug in the recent workflow versions table when filtering executions.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

@codecov
Copy link

codecov bot commented Jan 13, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@3e69b11). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #264   +/-   ##
=========================================
  Coverage          ?   63.85%           
=========================================
  Files             ?      370           
  Lines             ?     8110           
  Branches          ?     1441           
=========================================
  Hits              ?     5179           
  Misses            ?     2931           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e69b11...7906c20. Read the comment docs.

anrusina
anrusina reviewed Jan 13, 2022
View reviewed changes
src/components/Entities/EntityVersions.tsx
@@ -62,7 +62,7 @@ export const EntityVersions: React.FC<EntityVersionsProps> = ({
{ domain, project },
{
sort,
filter: [...baseFilters, ...filtersState.appliedFilters],
filter: baseFilters,
Copy link
Contributor

@anrusina anrusina Jan 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pianist038801 I'm trying to understand what bug exactly was fixed. Could you please add info to description of what was going wrong, and how it is working now.
Or maybe you can record from screen broken and fixed behavior.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the filter is not needed than filtersState mentions in line 50 and line 82 can also be removed 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anrusina That's a good catch. Just pushed fix!

anrusina
anrusina previously approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@anrusina anrusina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke-tested - works as expected.
@Professional0321 Can you please removed unneeded mentions of filtersState in that file.

@anrusina anrusina mentioned this pull request Jan 13, 2022
Closed
2 tasks
@anrusina anrusina added bug Something isn't working and removed bug Something isn't working labels Jan 13, 2022
@Pianist038801 Pianist038801 force-pushed the fix/recent-workflows-bug-on-filtering branch from 5fa0e2e to 7906c20 Compare January 14, 2022 15:27
@anrusina anrusina merged commit 0e82355 into master Jan 14, 2022
@anrusina anrusina deleted the fix/recent-workflows-bug-on-filtering branch January 14, 2022 15:49
flyte-bot added a commit that referenced this pull request Jan 14, 2022
@flyte-bot
chore(release): Release 0.39.1 [skip ci]
ca2e7ec 
## [0.39.1](http://github.com/lyft/flyteconsole/compare/v0.39.0...v0.39.1) (2022-01-14)

### Bug Fixes

* recent workflow bug on filtering executions ([#264](http://github.com/lyft/flyteconsole/issues/264)) #patch ([0e82355](http://github.com/lyft/flyteconsole/commit/0e823553bca31d0882c767e12235601e359a6475))
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.39.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

govalt pushed a commit that referenced this pull request Jan 15, 2022
@Pianist038801 @govalt
fix: recent workflow bug on filtering executions (#264) #patch
6af490f 
Signed-off-by: Pianist038801 <[email protected]>

Co-authored-by: Pianist038801 <[email protected]>
Signed-off-by: csirius <[email protected]>
govalt pushed a commit that referenced this pull request Jan 15, 2022
@flyte-bot @govalt
chore(release): Release 0.39.1 [skip ci]
91c3c95 
## [0.39.1](http://github.com/lyft/flyteconsole/compare/v0.39.0...v0.39.1) (2022-01-14)

### Bug Fixes

* recent workflow bug on filtering executions ([#264](http://github.com/lyft/flyteconsole/issues/264)) #patch ([0e82355](http://github.com/lyft/flyteconsole/commit/0e823553bca31d0882c767e12235601e359a6475))

Signed-off-by: csirius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anrusina anrusina anrusina approved these changes

@jsonporter jsonporter Awaiting requested review from jsonporter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pianist038801 @flyte-bot @anrusina