feat: Support for dynamic and nested workflows. #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progress progress progress Saving progress on bounds mapping progress progress progress - nested positions working progress, nested click working - checking nested-nested-nested probably want to revert this nvm moving ahead, saving before wiring up to props progress, good rollback point Progress Progress - top level parents now rendering children Nested view works for any level, now working to add click events progress progress progress progress progress progress progress pre refactor checkin Progress progress progress progress progress
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
reviewed
Mar 11, 2022
| @@ -77,13 +85,30 @@ export const getWorkflowId = (workflow: CompiledWorkflow): string => { | |||
| return workflow.template.id.name; | |||
| }; | |||
|
|
|||
| export const createWorkflowNodeFromDynamic = dw => { | |||
| // workflowNode: WorkflowNode | |||
anrusina
reviewed
Mar 11, 2022
src/server.tsx
Outdated
| @@ -28,6 +28,7 @@ export default function serverRenderer({ | |||
| const isDev = env === 'development'; | |||
| const isProd = env === 'production'; | |||
| let html = ''; | |||
| console.log('init server:'); | |||
anrusina
previously approved these changes
Mar 11, 2022
Signed-off-by: Jason Porter <[email protected]>
Signed-off-by: Jason Porter <[email protected]>
Signed-off-by: Jason Porter <[email protected]>
Signed-off-by: Jason Porter <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
- Coverage 66.43% 64.89% -1.54%
==========================================
Files 390 390
Lines 8746 8990 +244
Branches 1571 1626 +55
==========================================
+ Hits 5810 5834 +24
- Misses 2936 3156 +220
Continue to review full report at Codecov.
|
flyte-bot
added a commit
that referenced
this pull request
Mar 14, 2022
# [0.44.0](http://github.com/lyft/flyteconsole/compare/v0.43.0...v0.44.0) (2022-03-14) ### Bug Fixes * long node-id obscures task type ([#308](http://github.com/lyft/flyteconsole/issues/308)) ([50b5ef5](http://github.com/lyft/flyteconsole/commit/50b5ef51951301fb828ee0cf6f5bfc6cb1546920)) ### Features * Support for dynamic and nested workflows. ([#326](http://github.com/lyft/flyteconsole/issues/326)) ([5cd1ca5](http://github.com/lyft/flyteconsole/commit/5cd1ca57e9f5d64db96a1ebe9f8a19c1c14743fc))
|
🎉 This PR is included in version 0.44.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes support for a number of tickets including both dynamic workflows as well as support for n-depth nested workflows. Additionally, this release includes a version update of React Flow. While this is currently built against a React Flow pre-release version we will be updating once the major version (10.0.0) is released in the near future.
Includes:
Type
Are all requirements met?
Complete description
Includes React Flow pre-release
10.0.0-next.30as the new version supports nested graphs (read: subworkflows). More can be found here: https://github.com/wbkd/react-flowTracking Issues
https://github.com/flyteorg/flyteconsole/issues/297
https://github.com/flyteorg/flyteconsole/issues/295
https://github.com/flyteorg/flyteconsole/issues/301
Follow-up issue
NA