Add list of existing stats to assertion not-found failures #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlievieth
previously approved these changes
Sep 19, 2020
charlievieth
approved these changes
Sep 21, 2020
added 2 commits
September 21, 2020 11:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In more complex cases (e.g. with use of tags, deeply nested scopes), it is not always super obvious what the full name of a metric will end up being. This change lists the names of all recorded metrics in the failure message for assertions that fail due to an expected metric not being found, so that you can easily compare the expected metric name to the actually-generated metric name.