allow periodic flushes to Stop being emitted. #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new Stop() method and changes the behavior of the Start() method on a store just slightly. store.Start(), if called while a periodic flush goroutine is currently running, causes the existing goroutine to stop and be replaced with a new goroutine. That is, the caller can now change the rate of flushing with calls such as: store.Start(time.NewTicker(1*time.Second)) store.Start(time.NewTicker(100*time.Second)) store.Stop() will stop any existing running periodic flush goroutine. If called multiple times, it is a no-op.
danielmmetz
previously approved these changes
Dec 20, 2022
danielmmetz
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new Stop() method and changes the behavior of the Start() method on a store just slightly.
store.Start(), if called while a periodic flush goroutine is currently running, causes the existing goroutine to stop and be replaced with a new goroutine. That is, the caller can now change the rate of flushing with calls such as:
store.Stop() will stop any existing running periodic flush goroutine. If called multiple times, it is a no-op.