Merge apache 5994e43 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add extra_require for bigquery to setup.py * Refactor df_to_db and add df upload capability for BigQuery * Fix unit tests and clarify kwarg logic * Fix flake8 errors * Add minimum versions for bigquery dependencies * wrap to_gbq in try-catch block and raise error if pandas-gbq is missing * Fix linting error and make error more generic
…le selection is false (apache#7011)
* Fix js_data_mutator * Remove redundant line change * Add missing line changes
* chore: taking db dependencies out of requirements-dev.txt The deps on mysqlclient and psycopg2 * Fix unit tests * fix tox.ini * fix tests
…apache#7764) * Show generic error msg and hide stacktrace if feature flag is enabled * SHOW_STACKTRACE should not modify msg
…pache#7767) * Add check if TimegrainExpression col is None * Clean up TimestampExpression proxying logic * Remove redundant optionality from init
* feat: query based on all partitions * fix: address Beto's comments
Codecov Report
@@ Coverage Diff @@
## lyft-master #46 +/- ##
===============================================
+ Coverage 64.82% 64.91% +0.09%
===============================================
Files 468 468
Lines 22456 22493 +37
Branches 2472 2472
===============================================
+ Hits 14556 14602 +46
+ Misses 7765 7756 -9
Partials 135 135
Continue to review full report at Codecov.
|
xtinec
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge latest apache master to lyft master