Make Prometheus in revtr-sidecar listen on a cluster-local address #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag name is literal, and expects only an int. I've left the PRIVATE_IP env variable, but removed it from the flag. I submitted a PR to the revtr-sidecar repository to address this: NEU-SNS/revtr-sidecar#8 Once that PR is merged, assuming it does get merged, then I will update this again to specify a full address instead of just a port.
This includes an update to revtr-sidecar which changes the flag -prometheus.port to -prometheus.addr, and allows us to cause Prometheus to listen on a cluster-local address instead of a public interface.
stephen-soltesz
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Thank you for taking the time to improve this!
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Prometheus in revtr-sidecar listens on all interfaces. This PR causes it to listen only on the cluster-local pod address. It takes advantage of a new version of revtr-sidecar which enables this:
NEU-SNS/revtr-sidecar#8
This change is