Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change -flowtimeout to 5s #915

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented Nov 5, 2024

This changes the value of -flowtimeout from the default (30s) to 5s. As a result, a flow will be considered stopped, and its corresponding goroutine will be terminated and garbage-collected after 5 seconds of no new packets being observed.

See https://github.com/m-lab/dev-tracker/issues/800


This change is Reviewable

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any open issue with a summary of the rationale motivating this change? Including a link to that issue in the description would provide a breadcrumb to anyone who wanted to understand why this is needed and why it could be wise to preserve in the future, or at least to have more context about what went into the decision in case someone wants to change it in the future with less context.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

@robertodauria
Copy link
Contributor Author

Is there any open issue with a summary of the rationale motivating this change? Including a link to that issue in the description would provide a breadcrumb to anyone who wanted to understand why this is needed and why it could be wise to preserve in the future, or at least to have more context about what went into the decision in case someone wants to change it in the future with less context.

Added a link to the issue tracking the ongoing SYN flood to the PR description.

@robertodauria robertodauria merged commit d489ac4 into main Nov 5, 2024
2 of 3 checks passed
@robertodauria robertodauria deleted the sandbox-roberto-flowtimeout branch November 5, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants