Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Remove unused getMockReader #3351

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

linasm
Copy link
Collaborator

@linasm linasm commented Mar 12, 2021

What this PR does / why we need it:
Noticed some more leftovers, cleaning up.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE

Does this PR require updating code package or user-facing documentation?:
NONE

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #3351 (561bdf4) into master (49f8c14) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3351     +/-   ##
=========================================
- Coverage    72.3%    72.3%   -0.1%     
=========================================
  Files        1098     1098             
  Lines      102107   102107             
=========================================
- Hits        73903    73889     -14     
- Misses      23103    23113     +10     
- Partials     5101     5105      +4     
Flag Coverage Δ
aggregator 76.8% <ø> (-0.1%) ⬇️
cluster 84.9% <ø> (-0.1%) ⬇️
collector 84.3% <ø> (ø)
dbnode 78.9% <ø> (-0.1%) ⬇️
m3em 74.4% <ø> (ø)
m3ninx 73.6% <ø> (+<0.1%) ⬆️
metrics 19.8% <ø> (ø)
msg 74.4% <ø> (-0.2%) ⬇️
query 66.9% <ø> (ø)
x 80.5% <ø> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f8c14...561bdf4. Read the comment docs.

@linasm linasm merged commit 53c97e8 into master Mar 12, 2021
@linasm linasm deleted the linasm/remove-unused-getMockReader branch March 12, 2021 08:12
soundvibe added a commit that referenced this pull request Mar 15, 2021
* master:
  [dbnode] Remove unused getMockReader (#3351)
  [dbnode] Add back teardown of containers at end of Prometheus integration test (#3349)
  [query] Add series metadata label limit header for trimming response (#3348)

# Conflicts:
#	src/dbnode/storage/shard_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants