Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Add Graphite movingWindow() function #3484

Merged
merged 2 commits into from
May 10, 2021

Conversation

yyin-sc
Copy link
Collaborator

@yyin-sc yyin-sc commented May 8, 2021

What this PR does / why we need it:

Add movingWindow() functions

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington changed the title [query] Add movingWindow() support to graphite [query] Add Graphite movingWindow() function May 10, 2021
@robskillington robskillington enabled auto-merge (squash) May 10, 2021 07:29
@robskillington robskillington merged commit 58e9631 into m3db:master May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #3484 (be58f4d) into master (6ea9541) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3484     +/-   ##
========================================
- Coverage    55.9%   55.8%   -0.1%     
========================================
  Files         548     548             
  Lines       61188   61188             
========================================
- Hits        34212   34163     -49     
- Misses      23891   23930     +39     
- Partials     3085    3095     +10     
Flag Coverage Δ
aggregator 57.3% <ø> (ø)
cluster ∅ <ø> (∅)
collector 54.3% <ø> (ø)
dbnode 60.2% <ø> (-0.2%) ⬇️
m3em 46.4% <ø> (ø)
metrics 19.8% <ø> (ø)
msg 74.4% <ø> (-0.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea9541...be58f4d. Read the comment docs.

soundvibe added a commit that referenced this pull request May 10, 2021
* master:
  [query] Add Graphite movingWindow() function (#3484)
  [lint] Add missing build tags to linter configuration (#3480)
  [query] Fix Graphite nil arg not interpreted as explicit nil (#3481)
  [query] Fix Graphite context time window expansions not being cumulative
  [readme] Remove coverage badge due to CodeCov not able to execute (#3476)
  [query] Fix using median with aggregateWithWildcards and support more aggregate functions (#3469)
  [matcher] [coordinator] Add RequireNamespaceWatchOnInit option (#3468)
  [buildkite] Remove codecov uploading from unit tests (#3475)
  [aggregator] Add integration test for aggregator placement changes (#3465)
  [tools] Use streaming reads in read_data_files (#3474)
  [tools] Close the reader in read_data_files (#3473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants