Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] influxdb: write endpoint support for M3-Map-Tags-JSON header #3816

Conversation

mhoffm-aiven
Copy link
Contributor

What this PR does / why we need it:

This PR enables the M3-Map-Tags-JSON HTTP Header for the influxdb write endpoint similar to prometheus. Supports only adding/replacing a tag similar to what the Prometheus API does.

Support `M3-Map-Tags-JSON` for the influxdb write endpoint
Support `M3-Map-Tags-JSON` for the influxdb write endpoint

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2021

CLA assistant check
All committers have signed the CLA.

@mhoffm-aiven mhoffm-aiven force-pushed the mhoffm-influxdb-write-map-tags-json-cherrypick branch 2 times, most recently from 914d0db to d6e1f12 Compare October 5, 2021 14:27
@mhoffm-aiven
Copy link
Contributor Author

Test failures seem unrelated; can anyone help here?

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #3816 (e40889e) into master (e40889e) will not change coverage.
The diff coverage is n/a.

❗ Current head e40889e differs from pull request most recent head 82c11a9. Consider uploading reports for the commit 82c11a9 to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3816   +/-   ##
======================================
  Coverage    56.9%   56.9%           
======================================
  Files         552     552           
  Lines       63079   63079           
======================================
  Hits        35900   35900           
  Misses      23987   23987           
  Partials     3192    3192           
Flag Coverage Δ
aggregator 63.3% <0.0%> (ø)
cluster ∅ <0.0%> (∅)
collector 58.4% <0.0%> (ø)
dbnode 60.5% <0.0%> (ø)
m3em 46.4% <0.0%> (ø)
metrics 19.7% <0.0%> (ø)
msg 74.3% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e40889e...82c11a9. Read the comment docs.

@mhoffm-aiven mhoffm-aiven force-pushed the mhoffm-influxdb-write-map-tags-json-cherrypick branch 3 times, most recently from e8cc26c to e83a0fc Compare October 6, 2021 12:21
@mhoffm-aiven mhoffm-aiven force-pushed the mhoffm-influxdb-write-map-tags-json-cherrypick branch from e83a0fc to e9e0ee2 Compare October 7, 2021 10:35
Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for the contribution 👍

@robskillington robskillington merged commit 621bc81 into m3db:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants