This repository has been archived by the owner on Sep 6, 2019. It is now read-only.
Use references to struct fields in derive(Pwrite) implementation so it will work with non-Copy types
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will work with non-`Copy` types. Fixes m4b#15
|
Yup, you're right, need a new version of scroll, so pushed a new version of scroll 0.9.1 (and added you to authors :P), added a changelog, etc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #15. I had this laying around but I had written the patch atop #16 so I didn't want to submit a PR until that landed because GitHub is lousy at dealing with patches that have dependencies.
This might require explicitly bumping the required version of scroll used for the tests since it depends on m4b/scroll#35 .