#2197 Simplify Local File Readers #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request!
This PR removes optimizations intended for remote blob stores from the local storage reader (primarily caching and async IO). We may reimplement async in the future for local access, but for now, we've removed it.
This review of how the local access works was triggered by the ClickBench results, this change should help improve times for that benchmark but is not tailored for that benchmark (i.e. this is real-world beneficial, not just to improve benchmark scores)
Fixes: 2197
Please replace
<issue_number_goes_here>with the corresponding issue number.Thank you for contributing to Opteryx! 🎉