Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python >=3.11 inspect changes #160

Merged
merged 5 commits into from
May 23, 2023
Merged

python >=3.11 inspect changes #160

merged 5 commits into from
May 23, 2023

Conversation

Max-Herbold
Copy link
Contributor

ignore the extra params in getfullargspec. This is backwards compatible to <=3.10

@natezb
Copy link
Contributor

natezb commented May 16, 2023

Since we're dropping support for Python 2 (and your unpacking solution requires 3+ anyway), there's no need to attempt the import of getargspec(). I think we should just import getfullargspec() and use it directly.

@Max-Herbold
Copy link
Contributor Author

Max-Herbold commented May 17, 2023

maybe it's more verbose to breakout FullArgSpec(args, varargs, varkw, defaults, kwonlyargs, kwonlydefaults, annotations) to args, varargs, varkw, defaults, kwonlyargs, kwonlydefaults, annotations rather than args, varargs, varkw, defaults, *_.

@natezb natezb merged commit 029647a into mabuchilab:master May 23, 2023
@hakkelt hakkelt mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants