Merge pull request #272 from macbre/ignore-ssl-errors-handling

Improve handling of --ignore-ssl-errors option
macbre · Mar 22, 2021 · 24ce263 · 24ce263
2 parents 4fd258d + 24259b7
commit 24ce263
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -54,3 +54,6 @@ jobs:
 
     - name: Run bin/analyze-css.js for external file over HTTP
       run: ./bin/analyze-css.js --url http://s3.macbre.net/analyze-css/propertyResets.css -p | jq .metrics
+
+    - name: Run bin/analyze-css.js for external file over HTTPS (--ignore-ssl-errors)
+      run: ./bin/analyze-css.js --url https://s3.macbre.net/analyze-css/propertyResets.css --ignore-ssl-errors | jq .metrics
diff --git a/bin/analyze-css.js b/bin/analyze-css.js
@@ -67,7 +67,7 @@ else {
   return;
 }
 
-runnerOpts.ignoreSslErrors = program["ignore-ssl-errors"];
+runnerOpts.ignoreSslErrors = options.ignoreSslErrors === true;
 runnerOpts.noOffenders = program.offenders === false;
 runnerOpts.authUser = program["auth-user"];
 runnerOpts.authPass = program["auth-pass"];