Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dart-sass implementation instead of node-sass #323

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Use dart-sass implementation instead of node-sass #323

merged 3 commits into from
Jun 14, 2021

Conversation

macbre
Copy link
Owner

@macbre macbre commented Jun 14, 2021

Warning: LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

https://github.com/sass/node-sass#readme

Resolves #318

Using dart-sass 1.34.1 (Sass Compiler) [Dart] dart2js 2.13.1 (Dart Compiler) [Dart]

macbre added 3 commits June 14, 2021 16:54
@macbre
Install dart-sass instead of node-sass
bbe08b3 
https://github.com/sass/dart-sass#javascript-api
@macbre
CI - install sass npm package
66b4c96
@macbre
Use dart-sass implementation instead of node-sass
b20b064 
> Warning: LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.
> https://github.com/sass/node-sass#readme

Resolves #318

    Using dart-sass 1.34.1 (Sass Compiler) [Dart] dart2js 2.13.1 (Dart Compiler) [Dart]
@macbre macbre added this to the v0.13 milestone Jun 14, 2021
@macbre macbre enabled auto-merge June 14, 2021 16:03
@macbre macbre merged commit bcc8832 into devel Jun 14, 2021
@macbre macbre deleted the use/dart-sass branch June 14, 2021 16:04
@coveralls
Copy link

coveralls commented Jun 14, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 936409030

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 936308342: 0.0%
Covered Lines: 522
Relevant Lines: 522
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internals
Projects
None yet
Milestone
v0.13
Development

Successfully merging this pull request may close these issues.

Use Dart Sass instead of node-sass
2 participants
@macbre @coveralls