Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rav1e: update for libgit2 1.7.x #20532

Closed
wants to merge 1 commit into from
Closed

Conversation

mascguy
Copy link
Member

@mascguy mascguy commented Sep 21, 2023

Description

Proposed update for rav1e1, updating various deps - particularly those related to libgit2 - to fix build issues.

Creating as draft, as multiple iterations may be needed.

CC: @lukaso

@macportsbot
Copy link

Notifying maintainers:
@MarcusCalhoun-Lopez for port rav1e.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Sep 21, 2023
@mascguy mascguy added the wip Work in progress label Sep 21, 2023
@mascguy
Copy link
Member Author

mascguy commented Sep 22, 2023

Interestingly enough, while CI fails, rav1e builds fine locally. (At least for macOS 11 and 12; not able to create a macOS 13 VM yet.)

Not sure what's going on, but have some theories. Stay tuned...

@mascguy
Copy link
Member Author

mascguy commented Sep 22, 2023

@lukaso Lukas, can you test with my changes from this PR?

It may still fail due to libiconv, but the issues related to libgit2 at least appear to be fixed now. (Going to tackle the libiconv issue too, but that requires more digging into what the Rust build is doing under-the-hood.)

@mascguy mascguy force-pushed the mascguy-rav1e branch 2 times, most recently from 46896b1 to ada416a Compare September 22, 2023 16:47
@lukaso
Copy link
Contributor

lukaso commented Sep 23, 2023

@lukaso Lukas, can you test with my changes from this PR?

I'm not sure how do I do that. I've got a pretty complex build flow unfortunately.

It may still fail due to libiconv, but the issues related to libgit2 at least appear to be fixed now. (Going to tackle the libiconv issue too, but that requires more digging into what the Rust build is doing under-the-hood.)

Rust has just merged this PR: rust-lang/cc-rs#848 which should improve how it handles MACOSX_DEPLOYMENT_TARGET and friends. It might just be worth waiting for the next rust release before digging in. I suspect these problems will start to ease once rust's handling is better.

@pmetzger
Copy link
Member

I would suggest that we either finish this or close it.

@pmetzger
Copy link
Member

Closing this for now. Feel free to re-open it when you feel you have a version you would like to commit of course.

@pmetzger pmetzger closed this Jan 31, 2024
@mascguy mascguy deleted the mascguy-rav1e branch December 2, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: update wip Work in progress
Development

Successfully merging this pull request may close these issues.

5 participants