Remove non-interior mutability from non-generic types #633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #563.
Remove non-interior mutability from the types
NSString
,NSAttributedString
,NSData
, and a few others. Remaining are only the generic typesNSArray
,NSSet
,NSDictionary
,NSEnumerator
and so on, which will be handled by #587.The move of
NSString
was facilitated by #628.The changes to
NSData
might incur a performance cost if users decide to use the safeto_vec
over the unsafeas_slice_unchecked
, and the iteration methods are also less performant now.Notes:
std::io::Write
that require&mut
was changed to be implemented on&T
instead ofT
. This could be further improved with different impls onRetained<T>
.