This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
420 test coverage get available payment methods guest #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add - testGetPaymentMethodsFromGuestCart() - testGetPaymentMethodsFromAnotherCustomerCart() - testGetPaymentMethodsIfPaymentsAreNotSet() - testGetPaymentMethodsOfNonExistentCart() to \Magento\GraphQl\Quote\\Guest\GetAvailablePaymentMethodsTest
1. Add Magento/Payment/_files/disable_all_active_payment_methods.php
1. Fix typo errors
naydav
reviewed
Mar 8, 2019
| $processConfigData = function (Config $config, array $data) { | ||
| foreach ($data as $key => $value) { | ||
| $config->setDataByPath($key, $value); | ||
| $config->save(); |
There was a problem hiding this comment.
Looks like we don't need to call save after each iteration
There was a problem hiding this comment.
Looks like we don't need to call save after each iteration
@naydav , I've debugged your suggestions and I want inform you that we should use $config->save(); after each $config->setDataByPath($key, $value); if we want to save all config params.
By the way, the same approach uses in:
- dev/tests/integration/testsuite/Magento/Braintree/_files/payment_configuration.php
- dev/tests/integration/testsuite/Magento/Paypal/Fixtures/process_config_data.php
- dev/tests/integration/testsuite/Magento/SendFriend/Fixtures/process_config_data.php
- dev/tests/integration/testsuite/Magento/Signifyd/_files/website_configuration.php
Please approve and merge ;)
Thank you!
Merge remote-tracking branch 'origin/2.3-develop' into 420-test-coverage-getAvailablePaymentMethods-guest # Conflicts: # dev/tests/integration/testsuite/Magento/Payment/_files/disable_all_active_payment_methods.php # dev/tests/integration/testsuite/Magento/Payment/_files/disable_all_active_payment_methods_rollback.php
|
Hi @atwixfirster, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test coverage: GetAvailablePaymentMethodsTest for Guest #420
Pull request covers next cases:
Issue: #420