Grunt watch triggers entire page reload

[pooshok]

Preconditions

1. Magento 2.3.0
2. Compiling less with grunt and livereload

Steps to reproduce

1. grunt exec:<theme>
2. grunt less:<theme>
3. grunt watch

Expected result

less changes triggers styles refresh

Actual result

livereload triggers twice: first - refresh styles, second - reload entire page

Proposed solution

Revert back this #10836

[magento-engcom-team]

Hi @pooshok. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@pooshok do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[magento-engcom-team]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[ghost]

Hi @pooshok i'm not able to reproduce following steps you described in my case less changes triggers styles refresh.

[pooshok]

Hi @engcom-backlog-nazar. Looking to your "grunt watch --verbose" output I see you have "Live reloading" fired twice. So maybe the problem is still there.
I've noticed that issue on cart page: cart summary block reloaded on every livereload. Please check it on some page, containing some "slow js generated block" like this

[ghost]

@pooshok ivereload triggers twice: first - refresh styles, second - reload entire page
This trigger reload styles, not a page.

[rommelfreddy]

same issue.
same steps to reproduce...

[aledefreitas]

@pooshok @Fredwak

Since magento team most of the times don't really care enough to solve simple problems like this one, I came up with a simple solution to prevent entire page reloads:

Just comment out the following line: https://github.com/magento/magento2/blob/2.3-develop/dev/tools/grunt/configs/watch.js#L17

This way Live reload won't be triggered by .less files, and will only be triggered by .css files thus not reloading the entire page.
This speeds up theme development by quite a bunch.

[rommelfreddy]

great @aledefreitas !
this works for me! - thank you!

[riconeitzel]

it's still an issue in 2.3.x — we confirmed it in one of the core principles of theming in magento trainings.

#19544 (comment) fixed it

[lduivenvoorde-zz]

@pooshok @Fredwak

Since magento team most of the times don't really care enough to solve simple problems like this one, I came up with a simple solution to prevent entire page reloads:

Just comment out the following line: https://github.com/magento/magento2/blob/2.3-develop/dev/tools/grunt/configs/watch.js#L17

This way Live reload won't be triggered by .less files, and will only be triggered by .css files thus not reloading the entire page.
This speeds up theme development by quite a bunch.

For me, this comment solved the problem. Thanks!!!

[m2-assistant]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99039 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[m2-assistant]

Hi @torhoehn. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[magento-engcom-team]

Hi @pooshok. Thank you for your report.
The issue has been fixed in #22276 by @torhoehn in 2.3-develop branch
Related commit(s):

• 066a68febbd4cfb15e8cc271a984ce75bc8f6f3f

The fix will be available with the upcoming 2.3.2 release.