Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento\Reports\Model\ResourceModel\Order\Collection->getDateRange() - Error in code? #20128

Closed
realJustmike opened this issue Jan 8, 2019 · 6 comments
Assignees
Labels
Component: Reports Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@realJustmike
Copy link

Summary (*)

Magento 2.1.x

Examples (*)

Please see
Magento\Reports\Model\ResourceModel\Order\Collection->getDateRange()
on line 447:
$dateStart = $customStart ? $customStart : $dateEnd;

Proposed solution

$dateStart = $customStart ? $customStart : $dateStart;

@magento-engcom-team
Copy link
Contributor

Hi @realJustmike. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@realJustmike do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 8, 2019
@realJustmike
Copy link
Author

realJustmike commented Jan 8, 2019

Hi @realJustmike. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@realJustmike do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@irajneeshgupta irajneeshgupta self-assigned this Jan 8, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 8, 2019

Hi @irajneeshgupta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@irajneeshgupta irajneeshgupta added Component: Reports Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 8, 2019
@magento-engcom-team
Copy link
Contributor

@irajneeshgupta Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97498, MAGETWO-97499 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 8, 2019
milindsingh added a commit to opencommerce/magento2 that referenced this issue Jan 8, 2019
@TomashKhamlai TomashKhamlai added Progress: PR Created Indicates that Pull Request has been created to fix issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Jan 10, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @realJustmike. Thank you for your report.
The issue has been fixed in #20129 by @milindsingh in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

magento-engcom-team added a commit that referenced this issue Mar 5, 2019
…nd end date #20129

 - Merge Pull Request #20129 from opencommerce/magento2:2.3-develop-issue-20128
 - Merged commits:
   1. b1b6c3c
magento-engcom-team added a commit that referenced this issue Mar 5, 2019
…nd end date #20129

 - Merge Pull Request #20129 from opencommerce/magento2:2.3-develop-issue-20128
 - Merged commits:
   1. b1b6c3c
   2. 92dd7df
mage2pratik pushed a commit to mage2pratik/magento2 that referenced this issue Mar 6, 2019
@magento-engcom-team
Copy link
Contributor

Hi @realJustmike. Thank you for your report.
The issue has been fixed in #21589 by @mage2pratik in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 15, 2019
magento-engcom-team added a commit that referenced this issue Mar 15, 2019
…ame start and end date #21589

 - Merge Pull Request #21589 from mage2pratik/magento2:2.2-develop-PR-port-20129
 - Merged commits:
   1. 8874332
magento-engcom-team added a commit that referenced this issue Mar 15, 2019
…ame start and end date #21589

 - Merge Pull Request #21589 from mage2pratik/magento2:2.2-develop-PR-port-20129
 - Merged commits:
   1. 8874332
   2. a75958f
magento-engcom-team pushed a commit that referenced this issue Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Reports Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants