Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloadable product view layout #20187

Closed
melaxon opened this issue Jan 10, 2019 · 13 comments
Closed

Downloadable product view layout #20187

melaxon opened this issue Jan 10, 2019 · 13 comments
Assignees
@melaxon @GovindaSharma
Labels
Area: Design/Frontend Component: Downloadable Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@melaxon
Copy link
Member

melaxon commented Jan 10, 2019 •
edited
Loading

Preconditions (*)

  1. Magento 2.3.0 fresh installation, Luma
  2. All default settings, nothing special
  3. Any web browser
  4. Tried to re-install with the same result

Steps to reproduce (*)

  1. Install Magento 2.3.0
  2. Install one downloadable product and one simple product
  3. in frontend open both products in different browser tabs to compare the layout

Expected result (*)

  1. Normal layout is expected, like for example in case of simple product. See screenshot:
    https://gyazo.com/f4c7bb10d03da34528bd236700b93971

Actual result (*)

  1. The layout of downloadable product is broken:
    https://gyazo.com/945c9322b0fbef9dd145176738315784
  2. The price is duplicated for some reason
  3. Empty not used space on the right.
  4. Not sure why the word "links" appears on frontend (I guess only Samples would be sufficient)
  5. In case of downloadable product the settings "Block after Info Column" or "Product Info Column" will not change anything
  6. Qty is not shown up

Will try to play with catalog_product_view_type_downloadable.xml
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 10, 2019 •
edited by melaxon
Loading

Hi @melaxon. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@melaxon do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 10, 2019
@melaxon
Copy link
Member Author

melaxon commented Jan 10, 2019

@magento-engcom-team give me 2.3.0 instance

@magento-engcom-team
Copy link
Contributor

Hi @melaxon. Thank you for your request. I'm working on Magento 2.3.0 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @melaxon, here is your Magento instance.
Admin access: https://i-20187-2-3-0.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@melaxon
Copy link
Member Author

melaxon commented Jan 10, 2019

this is a screenshot from vanilla https://gyazo.com/9e8e39e335562927a8775e04b5028422

@shikhamis11 shikhamis11 self-assigned this Jan 11, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 11, 2019 •
edited by melaxon
Loading

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@shikhamis11 shikhamis11 added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Area: Design/Frontend Component: Downloadable labels Jan 11, 2019
@magento-engcom-team
Copy link
Contributor

@shikhamis11 Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97567 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 11, 2019
@shikhamis11 shikhamis11 removed their assignment Jan 11, 2019
@melaxon
Copy link
Member Author

melaxon commented Jan 11, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @melaxon. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @melaxon, here is your Magento instance.
Admin access: https://i-20187-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@melaxon
Copy link
Member Author

melaxon commented Jan 11, 2019

the issue is reproducible on 2.3-develop as well
https://gyazo.com/ba0e56ee5f204715075390523f72060b

@GovindaSharma GovindaSharma mentioned this issue Jan 12, 2019
Merged
4 tasks
@melaxon melaxon mentioned this issue Jan 12, 2019
Closed
2 tasks
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 14, 2019 •
edited by melaxon
Loading

Hi @GovindaSharma. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @melaxon. Thank you for your report.
The issue has been fixed in #20239 by @GovindaSharma in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

magento-engcom-team added a commit that referenced this issue Mar 8, 2019
@magento-engcom-team
ENGCOM-4399: Fixed issue #20187 Downloadble Price duplicate issue #20239
d90eb42 


 - Merge Pull Request #20239 from GovindaSharma/magento2:2.3-DevelopPR7
 - Merged commits:
   1. e6f6422
magento-engcom-team pushed a commit that referenced this issue Mar 8, 2019
@sidolov
ENGCOM-4399: Fixed issue #20187 Downloadble Price duplicate issue #20239
a1cbfc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melaxon melaxon

@GovindaSharma GovindaSharma

Labels
Area: Design/Frontend Component: Downloadable Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@melaxon @shikhamis11 @GovindaSharma @magento-engcom-team