Get Shipping Method as object from order instance gives undefined index.

[mahesh-rajawat]

Preconditions (*)

1. Magento 2.3.0
2. Magento 2.2.x

Steps to reproduce (*)

1. Create a downloadable or virtual product.
2. Place an order with this product.
3. In custom controller or anywhere load order with id.
   $order = $this->orderFactory->create()->load($orderId); //your order id
4. Now get shipping method as object.
   $order->getShippingMethod(true)->getMethod();
5. It gives below error
   Notice: Undefined offset: 1 in /Users/mahesh/contribute/mage226/vendor/magento/module-sales/Model/Order.php on line 1223

Expected result (*)

1. It should return Null if order has no shipping method, so developers can manage it from their end.

Actual result (*)

[magento-engcom-team]

Hi @maheshWebkul721. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@maheshWebkul721 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[magento-engcom-team]

@maheshWebkul721 Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97697, MAGETWO-97698 were created

[magento-engcom-team]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[magento-engcom-team]

Hi @maheshWebkul721. Thank you for your report.
The issue has been fixed in #20381 by @maheshWebkul721 in 2.3-develop branch
Related commit(s):

• 82b1707b9b5c3dab9c74ab6a9a11a93f98880515
• ccd301441585b21f23f8ae942ca4a2b0c05b06d1
• 36cab08ed239081170a038212ec1531ec136abd3

The fix will be available with the upcoming release.

[magento-engcom-team]

Hi @maheshWebkul721. Thank you for your report.
The issue has been fixed in #20866 by @maheshWebkul721 in 2.2-develop branch
Related commit(s):

• c495f31900cc2250bb63bcd57242d518aa894d92

The fix will be available with the upcoming 2.2.9 release.