-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error while installing Magento from scratch if Locale Resolver is injected in cli command #21752
Comments
Hi @Bartlomiejsz. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @Bartlomiejsz do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
@magento-engcom-team give me 2.3-develop instance |
Hi @Al3ks73. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @Al3ks73, here is your Magento instance. |
Hi @engcom-backlog-nazar. Thank you for working on this issue.
|
✅ Confirmed by @engcom-backlog-nazar Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
Hi @Bartlomiejsz. Thank you for your report.
The fix will be available with the upcoming 2.3.2 release. |
Add missing phpdoc clock
Add missing phpdoc clock
Accepted Public Pull Requests: - #21719: [Backport] Fix #21692 #21752 - logic in constructor of address validator and Locale Resolver check (by @Bartlomiejsz) Fixed GitHub Issues: - #21692: Incorrect constructor of Magento\Sales\Model\Order\Address\Validator (reported by @Bartlomiejsz) has been fixed in #21719 by @Bartlomiejsz in 2.2-develop branch Related commits: 1. 068eedf 2. 8a4cfa4 3. 43cc9a4 4. f77f54d 5. cece086 6. 67b1d0a
Summary (*)
Tested on 2.3, but exactly same code exists in this file on 2.2-develop branch.
Method
getDefaultLocale
ofMagento\Framework\Locale\Resolver
checks configuration incore_config_data
. The reason of it is that if this class or some other that have it injected in some parent (for exampleMagento\Sales\Model\Order\Address\Validator
) is injected in constructor in Cli Command in some custom module, installation of Magento fails.Examples (*)
Magento\Sales\Model\Order\Address\Validator
is injectedBase table or view not found: 1146 Table 'database.store_website' doesn't exist, query was: SELECT
store_website.* FROM
store_website"
Proposed solution
This is fixed under #21693
The text was updated successfully, but these errors were encountered: