Fix for issue magento/magento2#18630 #18633
Conversation
|
Hi @dverkade. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
ghost
mentioned this pull request
|
Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened. |
|
@dverkade the labels "community-insider-contribution Community Insider: Cream" are not automatically assigned, but partner-contribution label get auto assigned by magento-engcom-team. |
|
@milindsingh the community insider labels will be automatically assigned since last week or so. So this has been resolved already as far as I know. |
| * @returns boolean. | ||
| */ | ||
| this.value.equalityComparer = function (oldValue, newValue) { | ||
| return !oldValue && !newValue || oldValue === newValue; |
There was a problem hiding this comment.
Why do we need to change comparator behavior to achieve
the compare on the frontend is breaking because NULL != " "
?
There was a problem hiding this comment.
It exactly says what it is for. We get a NULL value, which is not the same as "". So that's why we need this change.
There was a problem hiding this comment.
@dverkade I mean this looks like kinda low-level change. Is there some other place in client code which may be adjusted instead of changing comparator behavior?
|
@dverkade, I am closing this PR now due to inactivity. |
|
This PR can be processed, it fixes the issues mentioned. |
|
Hi @sivaschenko, thank you for the review. |
…de-Zipcode-in-checkout-form-already-validated-on-page-load
|
Hi @dverkade, thank you for your contribution! |
Description
When in the
core_config_datatable the setting fortax/defaults/postcodeis NULL the compare on the frontend is breaking because NULL != " ". This fix resolves that issue.Fixed Issues
Manual testing scenarios
See steps in issue to reproduce original issue.