Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mexican regions #18896

Closed
wants to merge 1 commit into from
Closed

Add mexican regions #18896

wants to merge 1 commit into from

Conversation

lexcast
Copy link

@lexcast lexcast commented Oct 28, 2018 •
edited by sivaschenko
Loading

2.3 PR: #21180

Description (*)

Add mexican regions to magento

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to checkout page
  2. Select Mexico on address form
  3. See mexican regions as options on region select

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 28, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @lexcast. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@osrecio osrecio self-assigned this Oct 29, 2018
@lexcast lexcast force-pushed the feature_mexican_regions branch from ac58f96 to 0f95a4d Compare November 12, 2018 04:27
sivaschenko
sivaschenko reviewed Jan 18, 2019
View reviewed changes
app/code/Magento/Directory/Setup/UpgradeData.php
*/
private function getDataForMexico()
{
return [
Copy link
Member

@sivaschenko sivaschenko Jan 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lexcast thanks for your contribution! I compared the region list with the wiki list and looks like "Mexico City" (CMX) region is missing https://en.wikipedia.org/wiki/Template:Mexico_State-Abbreviation_Codes However, I'm not sure if it should be included

@sivaschenko sivaschenko self-assigned this Jan 18, 2019
lexcast
lexcast commented Jan 19, 2019
View reviewed changes
app/code/Magento/Directory/Setup/UpgradeData.php
'CAM' => 'Campeche',
'CHP' => 'Chiapas',
'CHH' => 'Chihuahua',
'CMX' => 'Ciudad de México',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sivaschenko, "Mexico City" is in this line, in spanish is "Ciudad de México"

@sivaschenko
Copy link
Member

Hi @lexcast thank you for the update, we'd like to merge this contribution to 2.3-develop branch first. Could you please create a forwardport?

@osrecio osrecio self-requested a review February 13, 2019 09:08
@osrecio osrecio mentioned this pull request Feb 13, 2019
Merged
4 tasks
@osrecio
Copy link
Member

osrecio commented Feb 13, 2019

Hi @sivaschenko I created a PR for 2.3 #21180 In order to merge this PR Soon for 2.2.

@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-4240 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@lexcast thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@miguelbalparda
Copy link
Contributor

This is quite interesting. For argentinian regions we have a composer module, do you think is it worth including in the core also? Keep in mind any country might want to add regions too.

@osrecio
Copy link
Member

osrecio commented Feb 15, 2019

Hi @miguelbalparda , IMHO all the countries should be welcome to the core.

We can work to create a PR to add Regions of Argentina. What do you think? If it is declined we will have an aswer 😄

@miguelbalparda
Copy link
Contributor

We are already working on this, will update you once all the work pending is completed.

magento-engcom-team added a commit that referenced this pull request Mar 16, 2019
@magento-engcom-team
ENGCOM-4242: [ForwardPort] #18896 Add Mexico Regions #21180
8f26b57 
 - Merge Pull Request #21180 from osrecio/magento2:FP_18896_AddMexicoStates
 - Merged commits:
   1. d09b512
   2. 6d52365
   3. c0f2632
   4. 0605d38
   5. f59817b
magento-engcom-team added a commit that referenced this pull request Mar 16, 2019
@magento-engcom-team
ENGCOM-4242: [ForwardPort] #18896 Add Mexico Regions #21180
29f5e93 
 - Merge Pull Request #21180 from osrecio/magento2:FP_18896_AddMexicoStates
 - Merged commits:
   1. d09b512
   2. 6d52365
   3. c0f2632
   4. 0605d38
   5. f59817b
   6. 12c2a1d
magento-engcom-team pushed a commit that referenced this pull request Mar 16, 2019
@sidolov
ENGCOM-4242: [ForwardPort] #18896 Add Mexico Regions #21180
a9d69c4
magento-engcom-team added a commit that referenced this pull request Mar 16, 2019
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.3-develop
931f2ea 
Accepted Public Pull Requests:
 - #21763: Spelling Correction (by @ansari-krish)
 - #21740: Removed extra whitespaces (by @yogeshsuhagiya)
 - #21731: Fixed wrong proxing in the inventory observer (by @VitaliyBoyko)
 - #21683: Correct spelling (by @ravi-chandra3197)
 - #21444: Disable dropdown in JavaScript and CSS Settings in developer configuration (by @ananth-iyer)
 - #21582: Fixed Whitespace issues for related, cross and upsell grids (by @amol2jcommerce)
 - #21600: Fixed typo mistake (by @yogeshsuhagiya)
 - #21468: Fix long string display horizontal scroll in all pages in admin (by @mageprince)
 - #21189: Fix/issue 18761 (by @DenisSaltanahmedov)
 - #21180: [ForwardPort] #18896 Add Mexico Regions (by @osrecio)
 - #20001: #13612 Fixed-Quantity_and_stock_status when visibility set to storefront throwing exception (by @aditisinghcedcoss)


Fixed GitHub Issues:
 - #167: Fatal error: Class 'Mage' not found (reported by @clockworkgeek) has been fixed in #21731 by @VitaliyBoyko in 2.3-develop branch
   Related commits:
     1. 3819dc1

 - #21384: JS minify field is not disabled in developer configuration (reported by @DanielRuf) has been fixed in #21444 by @ananth-iyer in 2.3-develop branch
   Related commits:
     1. a5bdc38
     2. ab2d0e4

 - #21541: Whitespace issues for related, cross and upsell grids (reported by @Zyles) has been fixed in #21582 by @amol2jcommerce in 2.3-develop branch
   Related commits:
     1. 9ab463f

 - #18761: Bug with REPLACE method in Advanced Prices in CSV Import  (reported by @kamilmaliszewski) has been fixed in #21189 by @DenisSaltanahmedov in 2.3-develop branch
   Related commits:
     1. a572ae2
     2. 6692e08

 - #13612: 1 exception(s): Exception #0 (Exception): Warning: Illegal offset type in isset or empty in /home/jewelrynest2/public_html/magento/vendor/magento/module-eav/Model/Entity/Attribute/Source/AbstractSource.php on line 76 (reported by @kamal3294) has been fixed in #20001 by @aditisinghcedcoss in 2.3-develop branch
   Related commits:
     1. 0df7243
     2. 887902b
sivaschenko
sivaschenko requested changes Mar 18, 2019
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lexcast can you please add missing commits including tests fix from the forward port

@sidolov
Copy link
Contributor

sidolov commented Apr 1, 2019

@lexcast , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Apr 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 1, 2019

Hi @lexcast, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko requested changes

@osrecio osrecio osrecio approved these changes

Assignees

@osrecio osrecio

@sivaschenko sivaschenko

Labels
Component: Directory Progress: needs update Release Line: 2.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lexcast @magento-cicd2 @magento-engcom-team @sivaschenko @osrecio @miguelbalparda @sidolov